Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix permission checks on starboard interactions & manage_cogs #176

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

andrewj-brown
Copy link
Member

The default_permissions() decorator lets DMs through. This is cringe - we want to use default_permissions so that the server's role & moderation processes are abstracted out of the bot's code, and future committees can just fiddle with discord settings.

A more long-term solution is to have a decorator, @requires_server or the like, so we can continue to use default_permissions and just require that some commands must be used in the server. (This also would fix several other DM-based errors this PR identifies.) However, for now, let's just switch them all to checks.has_permissions() instead.

grep -r permission shows the following cogs use permissions:

  • member_count: errors out on DMs anyway (should be fixed but who cares)
  • minecraft: uses has_permissions() and Member-type-checks anyway
  • remindme: has manual permission checks, these will throw AttributeError in DMs (should be fixed but who cares)
  • starboard: fixed
  • manage_cogs: fixed

@andrewj-brown
Copy link
Member Author

Using mega gamer admin powers to merge instantly. it's a 3-line change, and I don't want people /manage_cogs unload'ing shit while this PR waits.

...also fuck typechecking

@andrewj-brown andrewj-brown merged commit c304268 into main Nov 8, 2023
2 of 3 checks passed
@andrewj-brown andrewj-brown deleted the bruh branch November 8, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant